Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-2786 implement delete action in list view #13

Merged

Conversation

frasertweedale
Copy link
Contributor

Implement the delete action in the list view kebab menu. There is no confirmation dialog yet (to be implemented later; see HMS-2787).

@app-sre-bot
Copy link

Can one of the admins verify this patch?

Implement the delete action in the list view kebab menu.  There is
no confirmation dialog yet (to be implemented later; see HMS-2787).
@frasertweedale frasertweedale force-pushed the feature/list-kebab-delete branch from 2242463 to 32aae75 Compare October 17, 2023 13:26
Copy link
Contributor

@avisiedo avisiedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried the change and it works as expected; after the interactions the database is updated according to the delete action in the UI.

LGTM

@avisiedo avisiedo merged commit 7642a0f into podengo-project:main Oct 17, 2023
1 check passed
@frasertweedale frasertweedale deleted the feature/list-kebab-delete branch October 18, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants